lkml.org 
[lkml]   [2020]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] usb: raw-gadget: fix gadget endpoint selection
Date
Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:

> On Sat, May 09, 2020 at 11:02:13AM +0300, Felipe Balbi wrote:
>>
>> Hi,
>>
>> Andrey Konovalov <andreyknvl@google.com> writes:
>> >> here you're changing userspace ABI. Aren't we going to possibly break
>> >> some existing applications?
>> >
>> > Hi Felipe,
>> >
>> > I've been working on tests for Raw Gadget for the last few weeks [1],
>> > which revealed a few problems with the interface. This isn't yet
>> > included into any released kernel, so my hope that changing the ABI is
>> > OK during the rc stage.
>>
>> Fair enough. If that's okay with Greg, it's okay with me, but then how
>> do we include it into the -rc seen as it's not really a fix?
>>
>> Greg, are you okay with me including such large patches during the -rc?
>> They essentially add new IOCTLs to the raw-gadget interface.
>
> Yes, as the driver only went in for -rc1, it's fine to add fixes like
> this so late as we don't want to ship a -final with it in broken form.

Thanks, I'll prepare a pull request containing it.

cheers

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-05-12 08:42    [W:0.047 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site