Messages in this thread | | | Date | Tue, 12 May 2020 15:06:36 +0000 | From | Charles Keepax <> | Subject | Re: [PATCH v2 5/5] mfd: lochnagar: Move binding over to dtschema |
| |
On Tue, May 12, 2020 at 08:49:49AM -0500, Rob Herring wrote: > On Mon, May 04, 2020 at 04:47:57PM +0100, Charles Keepax wrote: > > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> > > --- > > > > Changes since v1: > > - Removed contains on the compatible > > - Moved all sub-nodes into here directly only using $ref for properties > > - As the regulator binding only contained subnodes that file is now deleted > > - Removed some pointless descriptions > > > > A little nervous about the amount of clock and regulator stuff this > > pulls into the MFD file, any comments on that welcome? Would it be worth > > looking into something along the lines of the definitions stuff to keep > > some of that out in the clock and regulator bindings? > > It's fine like this. Other than my comments on patch 3, looks fine. > Respin and I'll apply. >
Groovy thanks for the reviews.
Thanks, Charles
| |