Messages in this thread | | | Date | Tue, 12 May 2020 16:34:47 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH perf/urgent] perf tools: Fix is_bpf_image function logic |
| |
On Tue, May 12, 2020 at 11:09:02AM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, May 12, 2020 at 03:36:09PM +0200, Jiri Olsa escreveu: > > On Tue, May 12, 2020 at 10:32:23AM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Tue, May 12, 2020 at 02:23:10PM +0200, Jiri Olsa escreveu: > > > > Adrian reported that is_bpf_image is not working the way it was > > > > intended - passing on trampolines and dispatcher names. Instead > > > > it returned true for all the bpf names. > > > > > > > > The reason even this logic worked properly is that all bpf objects, > > > > even trampolines and dispatcher, were assigned DSO_BINARY_TYPE__BPF_IMAGE > > > > binary_type. > > > > > > > > The later for bpf_prog objects, the binary_type was fixed in bpf load event > > > > processing, which is executed after the ksymbol code. > > > > > > > > Fixing the is_bpf_image logic, so it properly recognizes trampoline > > > > and dispatcher objects. > > > > > > This is not applying on top of torvalds/master, not tip/perf/urgent, and > > > > right.. it's on top of your's perf/core.. I can rebase on perf/urgent > > You don't need to, this hasn't hit torvalds/master, it'll be in the next > merge window, the one for 5.8. >
perfect, thanks
jirka
| |