Messages in this thread | | | Date | Tue, 12 May 2020 21:59:10 +0800 | From | Leo Yan <> | Subject | Re: [PATCH] perf powerpc: Don't ignore sym-handling.c file |
| |
On Sat, May 09, 2020 at 04:51:13PM +0530, Ravi Bangoria wrote: > Commit 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue") > removed powerpc specific sym-handling.c file from Build. This wasn't > caught by build CI because all functions in this file are declared > as __weak in common code. Fix it. > > Fixes: 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue") > Reported-by: Sandipan Das <sandipan@linux.ibm.com> > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com> > --- > tools/perf/arch/powerpc/util/Build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/perf/arch/powerpc/util/Build b/tools/perf/arch/powerpc/util/Build > index e5c9504f8586..e86e210bf514 100644 > --- a/tools/perf/arch/powerpc/util/Build > +++ b/tools/perf/arch/powerpc/util/Build > @@ -2,6 +2,7 @@ perf-y += header.o > perf-y += kvm-stat.o > perf-y += perf_regs.o > perf-y += mem-events.o > +perf-y += sym-handling.o
My bad, thanks for fixing. FWIW:
Reviewed-by: Leo Yan <leo.yan@linaro.org>
> perf-$(CONFIG_DWARF) += dwarf-regs.o > perf-$(CONFIG_DWARF) += skip-callchain-idx.o > -- > 2.21.1 >
| |