Messages in this thread | | | Subject | Re: [PATCH] scsi: hisi_sas: display correct proc_name in sysfs | From | Jason Yan <> | Date | Tue, 12 May 2020 19:29:07 +0800 |
| |
在 2020/5/12 19:07, John Garry 写道: > On 12/05/2020 11:30, Jason Yan wrote: >> >> >> 在 2020/5/12 18:00, John Garry 写道: >>> On 12/05/2020 10:35, Jason Yan wrote: >>>> >>>> >>>> 在 2020/5/12 16:23, John Garry 写道: >>>>> On 12/05/2020 07:33, Jason Yan wrote: >>>>>> The 'proc_name' entry in sysfs for hisi_sas is 'null' now becuase >>>>>> it is >>>>>> not initialized in scsi_host_template. It looks like: >>>>>> >>>>>> [root@localhost ~]# cat /sys/class/scsi_host/host2/proc_name >>>>>> (null) >>>>>> >>>>> >>>>> hmmm.. it would be good to tell us what this buys us, apart from >>>>> the proc_name file. >>>>> >>>> >>>> When there is more than one storage cards(or controllers) in the >>>> system, I'm tring to find out which host is belong to which card. >>>> And then I found this in scsi_host in sysfs but the output is >>>> '(null)' which is odd. >>> >>> "dmesg | grep host" would give this info, like: >>> >>> root@(none)$ dmesg | grep host0 >>> [ 8.877245] scsi host0: hisi_sas_v2_hw >>> >> >> NO, if long time after the system boot, dmesg cannot get this >> infomation. It is flushed by other logs. > > > ok, so I don't see any other way to currently do this, even though using > proc_name is a bit suspect, so: > > Acked-by: John Garry <john.garry@huawei.com> > > And the $subject is not right. It should be simply "display proc_name in > sysfs". >
Thanks, will send v2 with right $subject.
Jason
> Thanks, > John > > .
| |