Messages in this thread | | | Date | Tue, 12 May 2020 18:09:54 -0500 | From | Rob Herring <> | Subject | Re: [RFC][PATCH 1/2] Add a layer of abstraction to use the memory reserved by device tree for ima buffer pass. |
| |
On Mon, May 04, 2020 at 01:38:28PM -0700, Prakhar Srivastava wrote: > Introduce a device tree layer for to read and store ima buffer > from the reserved memory section of a device tree.
But why do I need 'a layer of abstraction'? I don't like them.
> Signed-off-by: Prakhar Srivastava <prsriva@linux.microsoft.com> > --- > drivers/of/Kconfig | 6 ++ > drivers/of/Makefile | 1 + > drivers/of/of_ima.c | 165 ++++++++++++++++++++++++++++++++++++++++++++
Who are the users of this code and why does it need to be here? Most code for specific bindings are not in drivers/of/ but with the user. It doesn't sound like there's more than 1 user.
> include/linux/of.h | 34 +++++++++ > 4 files changed, 206 insertions(+) > create mode 100644 drivers/of/of_ima.c
| |