lkml.org 
[lkml]   [2020]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RFC v1 1/3] dt-bindings: nvmem: Add devicetree bindings for qfprom-efuse
Hi,

On Tue, May 12, 2020 at 11:18 AM Ravi Kumar Bokka <rbokka@codeaurora.org> wrote:
>
> This patch adds dt-bindings document for qfprom-efuse controller.
>
> Signed-off-by: Ravi Kumar Bokka <rbokka@codeaurora.org>
> ---
> .../devicetree/bindings/nvmem/qfprom-efuse.yaml | 40 ++++++++++++++++++++++
> 1 file changed, 40 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/nvmem/qfprom-efuse.yaml
>
> diff --git a/Documentation/devicetree/bindings/nvmem/qfprom-efuse.yaml b/Documentation/devicetree/bindings/nvmem/qfprom-efuse.yaml
> new file mode 100644
> index 0000000..d262c99
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/nvmem/qfprom-efuse.yaml
> @@ -0,0 +1,40 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/nvmem/qfprom-efuse.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Technologies Inc, QFPROM Efuse bindings
> +
> +maintainers:
> + - Ravi Kumar Bokka <rbokka@codeaurora.org>
> +
> +allOf:
> + - $ref: "nvmem.yaml#"
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,sc7180-qfprom-efuse
> +
> + reg:
> + maxItems: 3

Instead of this, add descriptions for the 3 items. AKA:

reg:
items:
- description: The base of the qfprom.
- description: The start of the raw region.
- description: The start of the mem region.

...but do you really need to break this down into 3 ranges? Why can't
you just do:

reg = <0 0x00780000 0 0x2100>;

Then you really don't need any description and you'd just have:

reg:
maxItems: 1


> +

Need something for clocks and clock-names, like:

clocks:
maxItems: 1

clock-names:
items:
- const: sec


> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/qcom,gcc-sc7180.h>
> +
> + efuse@780000 {
> + compatible = "qcom,sc7180-qfprom-efuse";
> + reg = <0 0x00780000 0 0x100>,
> + <0 0x00780120 0 0x7a0>,
> + <0 0x00782000 0 0x100>;
> + clocks = <&gcc GCC_SEC_CTRL_CLK_SRC>;
> + clock-names = "secclk";

nit: Folks usually don't like the names of clocks to end in "clk". We
know it's a clock. Just name this "sec" or even a local name like
"core".

\
 
 \ /
  Last update: 2020-05-13 01:04    [W:0.112 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site