Messages in this thread | | | Date | Tue, 12 May 2020 15:52:12 -0700 | From | Dmitry Torokhov <> | Subject | Re: [PATCH v2 1/4] dt-bindings: input: gpio-vibrator: Don't require enable-gpios |
| |
On Wed, May 13, 2020 at 12:22:02AM +0200, Ondrej Jirman wrote: > It is possible to turn the motor on/off just by enabling/disabling > the vcc-supply. > > Signed-off-by: Ondrej Jirman <megous@megous.com> > Acked-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/input/gpio-vibrator.yaml | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/input/gpio-vibrator.yaml b/Documentation/devicetree/bindings/input/gpio-vibrator.yaml > index 2384465eaa19..c700b640bd53 100644 > --- a/Documentation/devicetree/bindings/input/gpio-vibrator.yaml > +++ b/Documentation/devicetree/bindings/input/gpio-vibrator.yaml > @@ -24,7 +24,6 @@ properties: > > required: > - compatible > - - enable-gpios
Hmm we need at least one of the 2 (gpio and supply). Should we encode it in the binding?
Also, in the dirver code, I guess we need to switch to have regulator optional (so we are not given the dummy one) and bail if neither regulator nor GPIO is found.
Thanks.
-- Dmitry
| |