Messages in this thread | | | Date | Tue, 12 May 2020 16:14:25 -0500 | From | Corey Minyard <> | Subject | Re: [PATCH 1/1] char: ipmi: convert to use i2c_new_client_device() |
| |
On Thu, Mar 26, 2020 at 10:09:58PM +0100, Wolfram Sang wrote: > Move away from the deprecated API.
Well, I should have looked a little closer first... comment inline
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > drivers/char/ipmi/ipmi_ssif.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c > index 8ac390c2b514..2791b799e33d 100644 > --- a/drivers/char/ipmi/ipmi_ssif.c > +++ b/drivers/char/ipmi/ipmi_ssif.c > @@ -1945,8 +1945,8 @@ static int ssif_adapter_handler(struct device *adev, void *opaque) > if (adev->type != &i2c_adapter_type) > return 0; > > - addr_info->added_client = i2c_new_device(to_i2c_adapter(adev), > - &addr_info->binfo); > + addr_info->added_client = i2c_new_client_device(to_i2c_adapter(adev), > + &addr_info->binfo);
i2c_new_client_device returns an ERR_PTR, not NULL on error. So this needs some more work. I'll send something out soon.
-corey
> > if (!addr_info->adapter_name) > return 1; /* Only try the first I2C adapter by default. */ > -- > 2.20.1 >
| |