lkml.org 
[lkml]   [2020]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] iio: adc: exynos: Simplify Exynos7-specific init
Date
Hello Krzysztof,
Thanks for the patch.

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 11 May 2020 14:04
> To: Jonathan Cameron <jic23@kernel.org>; Hartmut Knaack
> <knaack.h@gmx.de>; Lars-Peter Clausen <lars@metafoo.de>; Peter Meerwald-
> Stadler <pmeerw@pmeerw.net>; Kukjin Kim <kgene@kernel.org>; Krzysztof
> Kozlowski <krzk@kernel.org>; linux-iio@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Alim Akhtar <alim.akhtar@samsung.com>
> Subject: [PATCH] iio: adc: exynos: Simplify Exynos7-specific init
>
> The Exynos7-specific code bits in ADC driver do not play with PHY:
> the field exynos_adc_data.needs_adc_phy is not set in exynos7_adc_data
> instance. Therefore the initialization code does not have to check if it
is true.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Tested on exynos7-espresso board so,
Tested-by: Alim Akhtar <alim.akhtar@samsung.com>

> ---
>
> Only build tested.
> ---
> drivers/iio/adc/exynos_adc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
index
> 22131a677445..219c8eb32d16 100644
> --- a/drivers/iio/adc/exynos_adc.c
> +++ b/drivers/iio/adc/exynos_adc.c
> @@ -449,9 +449,6 @@ static void exynos_adc_exynos7_init_hw(struct
> exynos_adc *info) {
> u32 con1, con2;
>
> - if (info->data->needs_adc_phy)
> - regmap_write(info->pmu_map, info->data->phy_offset, 1);
> -
> con1 = ADC_V2_CON1_SOFT_RESET;
> writel(con1, ADC_V2_CON1(info->regs));
>
> --
> 2.17.1


\
 
 \ /
  Last update: 2020-05-11 19:20    [W:0.063 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site