lkml.org 
[lkml]   [2020]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v8 09/10] scsi: ufs-exynos: add UFS host support for Exynos SoCs
Date
Hi Randy

> -----Original Message-----
> From: Randy Dunlap <rdunlap@infradead.org>
> Sent: 11 May 2020 08:43
> To: Alim Akhtar <alim.akhtar@samsung.com>; robh@kernel.org
> Cc: devicetree@vger.kernel.org; linux-scsi@vger.kernel.org; krzk@kernel.org;
> avri.altman@wdc.com; martin.petersen@oracle.com;
> kwmad.kim@samsung.com; stanley.chu@mediatek.com;
> cang@codeaurora.org; linux-samsung-soc@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v8 09/10] scsi: ufs-exynos: add UFS host support for Exynos
> SoCs
>
> On 5/10/20 7:00 PM, Alim Akhtar wrote:
> > diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig index
> > e2005aeddc2d..cc7e29c8c24f 100644
> > --- a/drivers/scsi/ufs/Kconfig
> > +++ b/drivers/scsi/ufs/Kconfig
> > @@ -160,3 +160,15 @@ config SCSI_UFS_BSG
> >
> > Select this if you need a bsg device node for your UFS controller.
> > If unsure, say N.
> > +
> > +config SCSI_UFS_EXYNOS
> > + bool "EXYNOS specific hooks to UFS controller platform driver"
> > + depends on SCSI_UFSHCD_PLATFORM && ARCH_EXYNOS ||
> COMPILE_TEST
>
> Since && has higher precedence than ||, I am thinking that this should be
>
> depends on SCSI_UFSHCD_PLATFORM && (ARCH_EXYNOS ||
> COMPILE_TEST)
>
Sure, I missed this, will add in next version.

> > + select PHY_SAMSUNG_UFS
> > + help
> > + This selects the EXYNOS specific additions to UFSHCD platform driver.
> > + UFS host on EXYNOS includes HCI and UNIPRO layer, and associates
> with
> > + UFS-PHY driver.
> > +
> > + Select this if you have UFS host controller on EXYNOS chipset.
> > + If unsure, say N.
>
>
> --
> ~Randy


\
 
 \ /
  Last update: 2020-05-11 19:03    [W:0.479 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site