lkml.org 
[lkml]   [2020]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] sched/debug: Fix requested task uclamp values shown in procfs
From
Date
On 11/05/2020 03:53, Pavankumar Kondeti wrote:
> The intention of commit 96e74ebf8d59 ("sched/debug: Add task uclamp
> values to SCHED_DEBUG procfs") was to print requested and effective
> task uclamp values. The requested values printed are read from p->uclamp,
> which holds the last effective values. Fix this by printing the values
> from p->uclamp_req.
>
> Fixes: 96e74ebf8d59 ("sched/debug: Add task uclamp values to SCHED_DEBUG procfs")
> Tested-and-reviewed-by: Valentin Schneider <valentin.schneider@arm.com>
> Signed-off-by: Pavankumar Kondeti <pkondeti@codeaurora.org>
> ---
>
> V2: Added "requested" prefix (suggested by Valentin)

Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>

>
> kernel/sched/debug.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
> index a562df5..77ecebd 100644
> --- a/kernel/sched/debug.c
> +++ b/kernel/sched/debug.c
> @@ -948,8 +948,8 @@ void proc_sched_show_task(struct task_struct *p, struct pid_namespace *ns,
> P(se.avg.util_est.enqueued);
> #endif
> #ifdef CONFIG_UCLAMP_TASK
> - __PS("uclamp.min", p->uclamp[UCLAMP_MIN].value);
> - __PS("uclamp.max", p->uclamp[UCLAMP_MAX].value);
> + __PS("requested uclamp.min", p->uclamp_req[UCLAMP_MIN].value);
> + __PS("requested uclamp.max", p->uclamp_req[UCLAMP_MAX].value);
> __PS("effective uclamp.min", uclamp_eff_value(p, UCLAMP_MIN));
> __PS("effective uclamp.max", uclamp_eff_value(p, UCLAMP_MAX));
> #endif

\
 
 \ /
  Last update: 2020-05-11 10:46    [W:0.037 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site