Messages in this thread | | | Subject | Re: [PATCH net-next 4/4] net: bcmgenet: add support for ethtool flow control | From | Florian Fainelli <> | Date | Mon, 11 May 2020 20:24:24 -0700 |
| |
On 5/11/2020 5:24 PM, Doug Berger wrote: > This commit extends the supported ethtool operations to allow MAC > level flow control to be configured for the bcmgenet driver. It > provides an example of how the new phy_set_pause function and the > phy_validate_pause function can be used to configure the desired > PHY advertising as well as how the phy_get_pause function can be > used for resolving negotiated pause modes which may be overridden > by the MAC. > > The ethtool utility can be used to change the configuration to enable > auto-negotiated symmetric and asymmetric modes as well as manually > enabling support for RX and TX Pause frames individually. > > Signed-off-by: Doug Berger <opendmb@gmail.com>
[snip]
Only if you need to respin this patch series, I would rename _flow_control_autoneg() to bcmgenet_flow_control_autoneg() or something shorter that still contains bcmgenet_ as a prefix for consistency.
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
| |