Messages in this thread | | | Subject | Re: [PATCH net-next 1/4] net: ethernet: validate pause autoneg setting | From | Florian Fainelli <> | Date | Mon, 11 May 2020 20:16:15 -0700 |
| |
On 5/11/2020 5:24 PM, Doug Berger wrote: > A comment in uapi/linux/ethtool.h states "Drivers should reject a > non-zero setting of @autoneg when autoneogotiation is disabled (or > not supported) for the link". > > That check should be added to phy_validate_pause() to consolidate > the code where possible. > > Fixes: 22b7d29926b5 ("net: ethernet: Add helper to determine if pause configuration is supported") > Signed-off-by: Doug Berger <opendmb@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
| |