Messages in this thread | | | From | Aisheng Dong <> | Subject | RE: [PATCH V2 2/2] dt-bindings: watchdog: Convert i.MX7ULP to json-schema | Date | Tue, 12 May 2020 03:10:07 +0000 |
| |
Hi Rob,
> From: Rob Herring <robh@kernel.org> > Sent: Tuesday, April 21, 2020 5:28 AM
[...]
> > + timeout-sec: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: | > > + Contains the watchdog timeout in seconds. > > This already has a definition in watchdog.yaml, just need: > > timeout-sec: true >
A bit interested what's the difference if not specifying it as we already have a reference to "watchdog.yaml#".
+allOf: + - $ref: "watchdog.yaml#"
I saw some mmc vendor yaml bindings seemed did not specifying the 'true' for the properties referenced from the parent "mmc-controller.yaml".
Would you help clarify a bit?
Regards Aisheng
> > + > > +required: > > + - compatible > > + - interrupts > > + - reg > > + - clocks > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/interrupt-controller/arm-gic.h> > > + #include <dt-bindings/clock/imx7ulp-clock.h> > > + > > + wdog1: watchdog@403d0000 { > > + compatible = "fsl,imx7ulp-wdt"; > > + reg = <0x403d0000 0x10000>; > > + interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&pcc2 IMX7ULP_CLK_WDG1>; > > + assigned-clocks = <&pcc2 IMX7ULP_CLK_WDG1>; > > + assigned-clocks-parents = <&scg1 IMX7ULP_CLK_FIRC_BUS_CLK>; > > + timeout-sec = <40>; > > + }; > > + > > +... > > -- > > 2.7.4 > >
| |