lkml.org 
[lkml]   [2020]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 17/18] mtd: Support kmsg dumper based on pstore/blk
On Mon, May 11, 2020 at 05:01:26PM +0800, WeiXiong Liao wrote:
> On 2020/5/11 AM 4:24, Kees Cook wrote:
> > [...]
> > + if (strlen(info->device) == 0) {
> > + dev_err(&mtd->dev, "mtd device must be supplied\n");
>
> mtd is NULL here, "mtd->dev" leads to error.
>
> > + return -EINVAL;
> > + }
> > + if (!info->kmsg_size) {
> > + dev_err(&mtd->dev, "no backend enabled\n");
>
> Also here.

Thanks! Fixed.

--
Kees Cook

\
 
 \ /
  Last update: 2020-05-12 01:17    [W:0.549 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site