Messages in this thread | | | Date | Mon, 11 May 2020 16:16:55 -0700 | From | Kees Cook <> | Subject | Re: [PATCH v7 17/18] mtd: Support kmsg dumper based on pstore/blk |
| |
On Mon, May 11, 2020 at 05:01:26PM +0800, WeiXiong Liao wrote: > On 2020/5/11 AM 4:24, Kees Cook wrote: > > [...] > > + if (strlen(info->device) == 0) { > > + dev_err(&mtd->dev, "mtd device must be supplied\n"); > > mtd is NULL here, "mtd->dev" leads to error. > > > + return -EINVAL; > > + } > > + if (!info->kmsg_size) { > > + dev_err(&mtd->dev, "no backend enabled\n"); > > Also here.
Thanks! Fixed.
-- Kees Cook
| |