lkml.org 
[lkml]   [2020]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 11/18] pstore/zone,blk: Add console frontend support
On Mon, May 11, 2020 at 08:38:32AM -0700, Randy Dunlap wrote:
> On 5/10/20 1:24 PM, Kees Cook wrote:
> > diff --git a/fs/pstore/Kconfig b/fs/pstore/Kconfig
> > index f18cd126d83f..f1484f751c5e 100644
> > --- a/fs/pstore/Kconfig
> > +++ b/fs/pstore/Kconfig
> > @@ -236,3 +236,15 @@ config PSTORE_BLK_PMSG_SIZE
> >
> > NOTE that, both Kconfig and module parameters can configure
> > pstore/blk, but module parameters have priority over Kconfig.
> > +
> > +config PSTORE_BLK_CONSOLE_SIZE
> > + int "Size in Kbytes of console to store"
>
> maybe of console log to store"
>
> since my console size is not measured in Kbytes.
>
> > + depends on PSTORE_BLK
> > + depends on PSTORE_CONSOLE
> > + default 64
> > + help
> > + This just sets size of console (console_size) for pstore/blk. The
>
> console log
>
> > + size is in KB and must be a multiple of 4.
> > +
> > + NOTE that, both Kconfig and module parameters can configure
> > + pstore/blk, but module parameters have priority over Kconfig.

Good points! I've fixed this and a typo in the ftrace Kconfig help.

--
Kees Cook

\
 
 \ /
  Last update: 2020-05-12 01:15    [W:0.060 / U:0.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site