lkml.org 
[lkml]   [2020]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] docs/devicetree: mailbox: fix trivial typo
From
Date
On 10. 05. 20 21:38, l4stpr0gr4m@gmail.com wrote:
> From: Kangmin Park <l4stpr0gr4m@gmail.com>
>
> Fix node id typo in example

I think it is more than typo. It is incorrect unit-address which doesn't
match the first address specified in the reg property of the node.

Here is line from dt binding spec.
"The unit-address must match the first address specified in the
reg property of the node."



>
> Signed-off-by: Kangmin Park <l4stpr0gr4m@gmail.com>

IIRC subject should start with dt-bindings:


> ---
> Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt
> index 4438432..ad76edc 100644
> --- a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt
> +++ b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt
> @@ -87,7 +87,7 @@ Example:
> ranges;
>
> /* APU<->RPU0 IPI mailbox controller */
> - ipi_mailbox_rpu0: mailbox@ff90400 {
> + ipi_mailbox_rpu0: mailbox@ff990400 {
> reg = <0xff990400 0x20>,
> <0xff990420 0x20>,
> <0xff990080 0x20>,
>

Change is correct.

With nits above applied please add my
Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

\
 
 \ /
  Last update: 2020-05-11 09:01    [W:0.046 / U:0.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site