Messages in this thread | | | Subject | Re: [PATCH V3 2/3] mm/hugetlb: Define a generic fallback for is_hugepage_only_range() | From | Anshuman Khandual <> | Date | Mon, 11 May 2020 08:44:39 +0530 |
| |
On 05/09/2020 03:52 AM, Mike Kravetz wrote: > On 5/7/20 8:07 PM, Anshuman Khandual wrote: >> There are multiple similar definitions for is_hugepage_only_range() on >> various platforms. Lets just add it's generic fallback definition for >> platforms that do not override. This help reduce code duplication. >> >> Cc: Russell King <linux@armlinux.org.uk> >> Cc: Catalin Marinas <catalin.marinas@arm.com> >> Cc: Will Deacon <will@kernel.org> >> Cc: Tony Luck <tony.luck@intel.com> >> Cc: Fenghua Yu <fenghua.yu@intel.com> >> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> >> Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com> >> Cc: Helge Deller <deller@gmx.de> >> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> >> Cc: Paul Mackerras <paulus@samba.org> >> Cc: Michael Ellerman <mpe@ellerman.id.au> >> Cc: Paul Walmsley <paul.walmsley@sifive.com> >> Cc: Palmer Dabbelt <palmer@dabbelt.com> >> Cc: Heiko Carstens <heiko.carstens@de.ibm.com> >> Cc: Vasily Gorbik <gor@linux.ibm.com> >> Cc: Christian Borntraeger <borntraeger@de.ibm.com> >> Cc: Yoshinori Sato <ysato@users.sourceforge.jp> >> Cc: Rich Felker <dalias@libc.org> >> Cc: "David S. Miller" <davem@davemloft.net> >> Cc: Thomas Gleixner <tglx@linutronix.de> >> Cc: Ingo Molnar <mingo@redhat.com> >> Cc: Borislav Petkov <bp@alien8.de> >> Cc: "H. Peter Anvin" <hpa@zytor.com> >> Cc: Mike Kravetz <mike.kravetz@oracle.com> >> Cc: Andrew Morton <akpm@linux-foundation.org> >> Cc: x86@kernel.org >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-ia64@vger.kernel.org >> Cc: linux-mips@vger.kernel.org >> Cc: linux-parisc@vger.kernel.org >> Cc: linuxppc-dev@lists.ozlabs.org >> Cc: linux-riscv@lists.infradead.org >> Cc: linux-s390@vger.kernel.org >> Cc: linux-sh@vger.kernel.org >> Cc: sparclinux@vger.kernel.org >> Cc: linux-mm@kvack.org >> Cc: linux-arch@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> >> --- >> arch/arm/include/asm/hugetlb.h | 6 ------ >> arch/arm64/include/asm/hugetlb.h | 6 ------ >> arch/ia64/include/asm/hugetlb.h | 1 + >> arch/mips/include/asm/hugetlb.h | 7 ------- >> arch/parisc/include/asm/hugetlb.h | 6 ------ >> arch/powerpc/include/asm/hugetlb.h | 1 + >> arch/riscv/include/asm/hugetlb.h | 6 ------ >> arch/s390/include/asm/hugetlb.h | 7 ------- >> arch/sh/include/asm/hugetlb.h | 6 ------ >> arch/sparc/include/asm/hugetlb.h | 6 ------ >> arch/x86/include/asm/hugetlb.h | 6 ------ >> include/linux/hugetlb.h | 9 +++++++++ >> 12 files changed, 11 insertions(+), 56 deletions(-) >> > <snip> >> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h >> index 43a1cef8f0f1..c01c0c6f7fd4 100644 >> --- a/include/linux/hugetlb.h >> +++ b/include/linux/hugetlb.h >> @@ -591,6 +591,15 @@ static inline unsigned int blocks_per_huge_page(struct hstate *h) >> >> #include <asm/hugetlb.h> >> >> +#ifndef is_hugepage_only_range >> +static inline int is_hugepage_only_range(struct mm_struct *mm, >> + unsigned long addr, unsigned long len) >> +{ >> + return 0; >> +} >> +#define is_hugepage_only_range is_hugepage_only_range >> +#endif >> + >> #ifndef arch_make_huge_pte >> static inline pte_t arch_make_huge_pte(pte_t entry, struct vm_area_struct *vma, >> struct page *page, int writable) >> > > Did you try building without CONFIG_HUGETLB_PAGE defined? I'm guessing
Yes I did for multiple platforms (s390, arm64, ia64, x86, powerpc etc).
> that you need a stub for is_hugepage_only_range(). Or, perhaps add this > to asm-generic/hugetlb.h? > There is already a stub (include/linux/hugetlb.h) when !CONFIG_HUGETLB_PAGE.
| |