lkml.org 
[lkml]   [2020]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/3] power: charger: max14577: Add proper dt-compatible strings
    Hi,

    On Thu, Feb 20, 2020 at 03:51:27PM +0100, Marek Szyprowski wrote:
    > Add device tree compatible strings and create proper modalias structures
    > to let this driver load automatically if compiled as module, because
    > max14577 MFD driver creates MFD cells with such compatible strings.
    >
    > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
    > ---
    > drivers/power/supply/max14577_charger.c | 9 +++++++++
    > 1 file changed, 9 insertions(+)
    >
    > diff --git a/drivers/power/supply/max14577_charger.c b/drivers/power/supply/max14577_charger.c
    > index 8a59feac6468..891ba9f6f295 100644
    > --- a/drivers/power/supply/max14577_charger.c
    > +++ b/drivers/power/supply/max14577_charger.c
    > @@ -623,6 +623,15 @@ static const struct platform_device_id max14577_charger_id[] = {
    > };
    > MODULE_DEVICE_TABLE(platform, max14577_charger_id);
    >
    > +static const struct of_device_id of_max14577_charger_dt_match[] = {
    > + { .compatible = "maxim,max77836-charger",
    > + .data = (void *)MAXIM_DEVICE_TYPE_MAX77836, },
    > + { .compatible = "maxim,max14577-charger",
    > + .data = (void *)MAXIM_DEVICE_TYPE_MAX14577, },
    > + { },
    > +};
    > +MODULE_DEVICE_TABLE(of, of_max14577_charger_dt_match);
    > +
    > static struct platform_driver max14577_charger_driver = {
    > .driver = {
    > .name = "max14577-charger",

    Independently of the discussion in patch 1 this is missing the link
    to the of table in platform_driver->driver->of_match_table.

    -- Sebastian
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2020-05-10 18:55    [W:4.119 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site