Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [patch V4 part 2 01/18] x86/entry/64: Move non entry code into .text section | Date | Sun, 10 May 2020 15:39:51 +0200 |
| |
Andy Lutomirski <luto@kernel.org> writes: > On Tue, May 5, 2020 at 7:14 AM Thomas Gleixner <tglx@linutronix.de> wrote: >> >> All ASM code which is not part of the entry functionality can move out into >> the .text section. No reason to keep it in the non-instrumentable entry >> section. > > Ick. How about just moving that code into another file altogether?
Peter wanted to do that separately.
>> +.pushsection .text, "ax" >> SYM_FUNC_START(native_load_gs_index) >> FRAME_BEGIN >> pushfq >> @@ -1058,6 +1063,7 @@ SYM_FUNC_START(native_load_gs_index) >> ret >> SYM_FUNC_END(native_load_gs_index) >> EXPORT_SYMBOL(native_load_gs_index) >> +.popsection > > native_load_gs_index is toast if it gets instrumented in the wrong way.
I'll keep it in the noinstr section then.
Thanks,
tglx
| |