lkml.org 
[lkml]   [2020]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/4] kthreads: minor kthreadd refactoring
    Date
    From: "J. Bruce Fields" <bfields@redhat.com>

    Trivial refactoring, no change in behavior.

    Not really necessary, a separate function for the inner loop just seems
    a little nicer to me.

    Signed-off-by: J. Bruce Fields <bfields@redhat.com>
    ---
    kernel/kthread.c | 33 +++++++++++++++++++--------------
    1 file changed, 19 insertions(+), 14 deletions(-)

    diff --git a/kernel/kthread.c b/kernel/kthread.c
    index bfbfa481be3a..4217fded891a 100644
    --- a/kernel/kthread.c
    +++ b/kernel/kthread.c
    @@ -578,6 +578,24 @@ int kthread_stop(struct task_struct *k)
    }
    EXPORT_SYMBOL(kthread_stop);

    +void kthread_do_work(void)
    +{
    + spin_lock(&kthread_create_lock);
    + while (!list_empty(&kthread_create_list)) {
    + struct kthread_create_info *create;
    +
    + create = list_entry(kthread_create_list.next,
    + struct kthread_create_info, list);
    + list_del_init(&create->list);
    + spin_unlock(&kthread_create_lock);
    +
    + create_kthread(create);
    +
    + spin_lock(&kthread_create_lock);
    + }
    + spin_unlock(&kthread_create_lock);
    +}
    +
    int kthreadd(void *unused)
    {
    struct task_struct *tsk = current;
    @@ -597,20 +615,7 @@ int kthreadd(void *unused)
    schedule();
    __set_current_state(TASK_RUNNING);

    - spin_lock(&kthread_create_lock);
    - while (!list_empty(&kthread_create_list)) {
    - struct kthread_create_info *create;
    -
    - create = list_entry(kthread_create_list.next,
    - struct kthread_create_info, list);
    - list_del_init(&create->list);
    - spin_unlock(&kthread_create_lock);
    -
    - create_kthread(create);
    -
    - spin_lock(&kthread_create_lock);
    - }
    - spin_unlock(&kthread_create_lock);
    + kthread_do_work();
    }

    return 0;
    --
    2.26.2
    \
     
     \ /
      Last update: 2020-05-01 18:02    [W:2.933 / U:0.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site