Messages in this thread | | | Subject | Re: [PATCH v2 2/2] ftrace/selftest: make unresolved cases cause failure if --fail-unresolved set | From | shuah <> | Date | Fri, 1 May 2020 08:25:50 -0600 |
| |
On 5/1/20 3:42 AM, Masami Hiramatsu wrote: > On Wed, 19 Feb 2020 20:39:41 +0900 > Masami Hiramatsu <mhiramat@kernel.org> wrote: > >> On Wed, 19 Feb 2020 09:33:30 +0000 >> Alan Maguire <alan.maguire@oracle.com> wrote: >> >>> Currently, ftracetest will return 1 (failure) if any unresolved cases >>> are encountered. The unresolved status results from modules and >>> programs not being available, and as such does not indicate any >>> issues with ftrace itself. As such, change the behaviour of >>> ftracetest in line with unsupported cases; if unsupported cases >>> happen, ftracetest still returns 0 unless --fail-unsupported. Here >>> --fail-unresolved is added and the default is to return 0 if >>> unresolved results occur. >>> >> >> OK, this looks good to me. One note, with this change, ftracetest doesn't >> fail even if your test environment is not well prepared anymore. >> >> Acked-by: Masami Hiramatsu <mhiramat@kernel.org> > > Hi Shuah, > Could you pick this up? > > Po-Hsu Lin seemed to face same problem recently. If this applied, it will be solved. >
Sorry about this. I will get these in
thanks, -- Shuah
| |