Messages in this thread Patch in this message | | | Date | Fri, 1 May 2020 10:15:18 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH 1/3] selftests/ftrace: Make XFAIL green color |
| |
On Fri, 1 May 2020 22:37:41 +0900 Masami Hiramatsu <mhiramat@kernel.org> wrote:
> Since XFAIL (Expected Failure) is expected to fail the test, which > means that test case works as we expected. IOW, XFAIL is same as > PASS. So make it green.
THANK YOU!!!! That's been annoying me for some time ;-)
BIG Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
> > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org> > --- > tools/testing/selftests/ftrace/ftracetest | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest > index 063ecb290a5a..72e837d0dfc1 100755 > --- a/tools/testing/selftests/ftrace/ftracetest > +++ b/tools/testing/selftests/ftrace/ftracetest > @@ -273,7 +273,7 @@ eval_result() { # sigval > return $UNSUPPORTED_RESULT # depends on use case > ;; > $XFAIL) > - prlog " [${color_red}XFAIL${color_reset}]" > + prlog " [${color_green}XFAIL${color_reset}]" > XFAILED_CASES="$XFAILED_CASES $CASENO" > return 0 > ;;
| |