lkml.org 
[lkml]   [2020]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 40/80] ALSA: usx2y: Fix potential NULL dereference
    Date
    From: Takashi Iwai <tiwai@suse.de>

    commit 7686e3485253635c529cdd5f416fc640abaf076f upstream.

    The error handling code in usX2Y_rate_set() may hit a potential NULL
    dereference when an error occurs before allocating all us->urb[].
    Add a proper NULL check for fixing the corner case.

    Reported-by: Lin Yi <teroincn@gmail.com>
    Cc: <stable@vger.kernel.org>
    Link: https://lore.kernel.org/r/20200420075529.27203-1-tiwai@suse.de
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/usb/usx2y/usbusx2yaudio.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/sound/usb/usx2y/usbusx2yaudio.c
    +++ b/sound/usb/usx2y/usbusx2yaudio.c
    @@ -691,6 +691,8 @@ static int usX2Y_rate_set(struct usX2Yde
    us->submitted = 2*NOOF_SETRATE_URBS;
    for (i = 0; i < NOOF_SETRATE_URBS; ++i) {
    struct urb *urb = us->urb[i];
    + if (!urb)
    + continue;
    if (urb->status) {
    if (!err)
    err = -ENODEV;

    \
     
     \ /
      Last update: 2020-05-01 15:59    [W:2.326 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site