lkml.org 
[lkml]   [2020]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 59/80] remoteproc: Fix wrong rvring index computation
    Date
    From: Clement Leger <cleger@kalray.eu>

    commit 00a0eec59ddbb1ce966b19097d8a8d2f777e726a upstream.

    Index of rvring is computed using pointer arithmetic. However, since
    rvring->rvdev->vring is the base of the vring array, computation
    of rvring idx should be reversed. It previously lead to writing at negative
    indices in the resource table.

    Signed-off-by: Clement Leger <cleger@kalray.eu>
    Link: https://lore.kernel.org/r/20191004073736.8327-1-cleger@kalray.eu
    Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Cc: Doug Anderson <dianders@chromium.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/remoteproc/remoteproc_core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/remoteproc/remoteproc_core.c
    +++ b/drivers/remoteproc/remoteproc_core.c
    @@ -284,7 +284,7 @@ void rproc_free_vring(struct rproc_vring
    {
    int size = PAGE_ALIGN(vring_size(rvring->len, rvring->align));
    struct rproc *rproc = rvring->rvdev->rproc;
    - int idx = rvring->rvdev->vring - rvring;
    + int idx = rvring - rvring->rvdev->vring;
    struct fw_rsc_vdev *rsc;

    dma_free_coherent(rproc->dev.parent, size, rvring->va, rvring->dma);

    \
     
     \ /
      Last update: 2020-05-01 15:59    [W:2.620 / U:0.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site