lkml.org 
[lkml]   [2020]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.6 030/106] clk: asm9260: fix __clk_hw_register_fixed_rate_with_accuracy typo
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    commit 924ed1f5c181132897c5928af7f3afd28792889c upstream.

    The __clk_hw_register_fixed_rate_with_accuracy() function (with two '_')
    does not exist, and apparently never did:

    drivers/clk/clk-asm9260.c: In function 'asm9260_acc_init':
    drivers/clk/clk-asm9260.c:279:7: error: implicit declaration of function '__clk_hw_register_fixed_rate_with_accuracy'; did you mean 'clk_hw_register_fixed_rate_with_accuracy'? [-Werror=implicit-function-declaration]
    279 | hw = __clk_hw_register_fixed_rate_with_accuracy(NULL, NULL, pll_clk,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    | clk_hw_register_fixed_rate_with_accuracy
    drivers/clk/clk-asm9260.c:279:5: error: assignment to 'struct clk_hw *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
    279 | hw = __clk_hw_register_fixed_rate_with_accuracy(NULL, NULL, pll_clk,
    | ^

    >From what I can tell, __clk_hw_register_fixed_rate() is the correct
    API here, so use that instead.

    Fixes: 728e3096741a ("clk: asm9260: Use parent accuracy in fixed rate clk")
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Link: https://lkml.kernel.org/r/20200408155402.2138446-1-arnd@arndb.de
    Signed-off-by: Stephen Boyd <sboyd@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/clk/clk-asm9260.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/clk/clk-asm9260.c
    +++ b/drivers/clk/clk-asm9260.c
    @@ -276,7 +276,7 @@ static void __init asm9260_acc_init(stru

    /* TODO: Convert to DT parent scheme */
    ref_clk = of_clk_get_parent_name(np, 0);
    - hw = __clk_hw_register_fixed_rate_with_accuracy(NULL, NULL, pll_clk,
    + hw = __clk_hw_register_fixed_rate(NULL, NULL, pll_clk,
    ref_clk, NULL, NULL, 0, rate, 0,
    CLK_FIXED_RATE_PARENT_ACCURACY);


    \
     
     \ /
      Last update: 2020-05-01 15:43    [W:5.042 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site