lkml.org 
[lkml]   [2020]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 033/117] net: dsa: b53: Fix ARL register definitions
    Date
    From: Florian Fainelli <f.fainelli@gmail.com>

    [ Upstream commit c2e77a18a7ed65eb48f6e389b6a59a0fd753646a ]

    The ARL {MAC,VID} tuple and the forward entry were off by 0x10 bytes,
    which means that when we read/wrote from/to ARL bin index 0, we were
    actually accessing the ARLA_RWCTRL register.

    Fixes: 1da6df85c6fb ("net: dsa: b53: Implement ARL add/del/dump operations")
    Reviewed-by: Andrew Lunn <andrew@lunn.ch>
    Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/dsa/b53/b53_regs.h | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/net/dsa/b53/b53_regs.h
    +++ b/drivers/net/dsa/b53/b53_regs.h
    @@ -294,7 +294,7 @@
    *
    * BCM5325 and BCM5365 share most definitions below
    */
    -#define B53_ARLTBL_MAC_VID_ENTRY(n) (0x10 * (n))
    +#define B53_ARLTBL_MAC_VID_ENTRY(n) ((0x10 * (n)) + 0x10)
    #define ARLTBL_MAC_MASK 0xffffffffffffULL
    #define ARLTBL_VID_S 48
    #define ARLTBL_VID_MASK_25 0xff
    @@ -306,7 +306,7 @@
    #define ARLTBL_VALID_25 BIT(63)

    /* ARL Table Data Entry N Registers (32 bit) */
    -#define B53_ARLTBL_DATA_ENTRY(n) ((0x10 * (n)) + 0x08)
    +#define B53_ARLTBL_DATA_ENTRY(n) ((0x10 * (n)) + 0x18)
    #define ARLTBL_DATA_PORT_ID_MASK 0x1ff
    #define ARLTBL_TC(tc) ((3 & tc) << 11)
    #define ARLTBL_AGE BIT(14)

    \
     
     \ /
      Last update: 2020-05-01 15:33    [W:3.628 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site