lkml.org 
[lkml]   [2020]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 65/70] of: unittest: kmemleak on changeset destroy
    Date
    From: Frank Rowand <frank.rowand@sony.com>

    [ Upstream commit b3fb36ed694b05738d45218ea72cf7feb10ce2b1 ]

    kmemleak reports several memory leaks from devicetree unittest.
    This is the fix for problem 1 of 5.

    of_unittest_changeset() reaches deeply into the dynamic devicetree
    functions. Several nodes were left with an elevated reference
    count and thus were not properly cleaned up. Fix the reference
    counts so that the memory will be freed.

    Fixes: 201c910bd689 ("of: Transactional DT support.")
    Reported-by: Erhard F. <erhard_f@mailbox.org>
    Signed-off-by: Frank Rowand <frank.rowand@sony.com>
    Signed-off-by: Rob Herring <robh@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/of/unittest.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
    index 91e6891b777b6..109497dbfba08 100644
    --- a/drivers/of/unittest.c
    +++ b/drivers/of/unittest.c
    @@ -544,6 +544,10 @@ static void __init of_unittest_changeset(void)
    mutex_unlock(&of_mutex);

    of_changeset_destroy(&chgset);
    +
    + of_node_put(n1);
    + of_node_put(n2);
    + of_node_put(n21);
    #endif
    }

    --
    2.20.1


    \
     
     \ /
      Last update: 2020-05-01 15:27    [W:4.047 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site