lkml.org 
[lkml]   [2020]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 25/70] ALSA: hda: Remove ASUS ROG Zenith from the blacklist
    Date
    From: Takashi Iwai <tiwai@suse.de>

    [ Upstream commit a8cf44f085ac12c0b5b8750ebb3b436c7f455419 ]

    The commit 3c6fd1f07ed0 ("ALSA: hda: Add driver blacklist") added a
    new blacklist for the devices that are known to have empty codecs, and
    one of the entries was ASUS ROG Zenith II (PCI SSID 1043:874f).
    However, it turned out that the very same PCI SSID is used for the
    previous model that does have the valid HD-audio codecs and the change
    broke the sound on it.

    This patch reverts the corresponding entry as a temporary solution.
    Although Zenith II and co will see get the empty HD-audio bus again,
    it'd be merely resource wastes and won't affect the functionality,
    so it's no end of the world. We'll need to address this later,
    e.g. by either switching to DMI string matching or using PCI ID &
    SSID pairs.

    Fixes: 3c6fd1f07ed0 ("ALSA: hda: Add driver blacklist")
    Reported-by: Johnathan Smithinovic <johnathan.smithinovic@gmx.at>
    Cc: <stable@vger.kernel.org>
    Link: https://lore.kernel.org/r/20200419071926.22683-1-tiwai@suse.de
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/pci/hda/hda_intel.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
    index faf2554397021..da9f6749b3be2 100644
    --- a/sound/pci/hda/hda_intel.c
    +++ b/sound/pci/hda/hda_intel.c
    @@ -1978,7 +1978,6 @@ static const struct hdac_io_ops pci_hda_io_ops = {
    * should be ignored from the beginning.
    */
    static const struct snd_pci_quirk driver_blacklist[] = {
    - SND_PCI_QUIRK(0x1043, 0x874f, "ASUS ROG Zenith II / Strix", 0),
    SND_PCI_QUIRK(0x1462, 0xcb59, "MSI TRX40 Creator", 0),
    SND_PCI_QUIRK(0x1462, 0xcb60, "MSI TRX40", 0),
    {}
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-05-01 15:26    [W:7.049 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site