Messages in this thread | | | Subject | Re: [PATCH] MIPS: tools: Show result for loongson3-llsc-check | From | Tiezhu Yang <> | Date | Sat, 2 May 2020 11:33:11 +0800 |
| |
On 05/01/2020 05:48 PM, Sergei Shtylyov wrote: > Hello! > > On 30.04.2020 15:36, Tiezhu Yang wrote: > >> It is better to show the result before loongson3-llsc-check exit, >> otherwise we can see nothing if the return status is EXIT_SUCCESS, >> it seems confusing. >> >> E.g. without this patch: >> >> [loongson@localhost tools]$ ./loongson3-llsc-check ../../../vmlinux >> [loongson@localhost tools]$ >> >> With this patch: >> >> [loongson@localhost tools]$ ./loongson3-llsc-check ../../../vmlinux >> loongson3-llsc-check returns success >> [loongson@localhost tools]$ >> >> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> >> --- >> arch/mips/tools/loongson3-llsc-check.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/mips/tools/loongson3-llsc-check.c >> b/arch/mips/tools/loongson3-llsc-check.c >> index 0ebddd0..facd016 100644 >> --- a/arch/mips/tools/loongson3-llsc-check.c >> +++ b/arch/mips/tools/loongson3-llsc-check.c >> @@ -303,5 +303,7 @@ int main(int argc, char *argv[]) >> out_close: >> close(vmlinux_fd); >> out_ret: >> + fprintf(stdout, "loongson3-llsc-check %s\n", >> + status ? "returns failure" : "returns success"); > > Why not "loongson3-llsc-check returns %s\n"?
Hi Sergei,
Sorry for the late reply, thanks for your review, I will send v2.
Thanks, Tiezhu Yang
> >> return status; >> } >> > > MBR, Sergei
| |