Messages in this thread | | | From | Martin Blumenstingl <> | Date | Fri, 1 May 2020 23:53:08 +0200 | Subject | Re: [PATCH RFC v2 02/11] dt-bindings: net: dwmac-meson: Document the "timing-adjustment" clock |
| |
Hi Rob,
On Fri, May 1, 2020 at 11:09 PM Rob Herring <robh@kernel.org> wrote: > > On Wed, 29 Apr 2020 22:16:35 +0200, Martin Blumenstingl wrote: > > The PRG_ETHERNET registers can add an RX delay in RGMII mode. This > > requires an internal re-timing circuit whose input clock is called > > "timing adjustment clock". Document this clock input so the clock can be > > enabled as needed. > > > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > --- > > .../devicetree/bindings/net/amlogic,meson-dwmac.yaml | 10 +++++++--- > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > My bot found errors running 'make dt_binding_check' on your patch: > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.example.dt.yaml: ethernet@c9410000: clocks: Additional items are not allowed ([4294967295] was unexpected) > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.example.dt.yaml: ethernet@c9410000: clocks: [[4294967295], [4294967295], [4294967295], [4294967295]] is too long > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.example.dt.yaml: ethernet@c9410000: clocks: Additional items are not allowed ([4294967295] was unexpected) > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.example.dt.yaml: ethernet@c9410000: clocks: [[4294967295], [4294967295], [4294967295], [4294967295]] is too long I am seeing this on my own build machine as well, but only for the .yaml example The .dts example does not emit this warning
Also I don't see what's wrong with my way of describing the new, optional clock and it's clock-name Can you please point me in the right direction here?
Thank you! Martin
| |