lkml.org 
[lkml]   [2020]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH hmm v2 3/5] drm/amdgpu: remove dead code after hmm_range_fault()
    Date
    From: Jason Gunthorpe <jgg@mellanox.com>

    Since amdgpu does not use the snapshot mode of hmm_range_fault() a
    successful return already proves that all entries in the pfns are
    HMM_PFN_VALID, there is no need to check the return result of
    hmm_device_entry_to_page().

    Acked-by: Felix Kuehling <Felix.Kuehling@amd.com>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    ---
    drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 16 ++++++----------
    1 file changed, 6 insertions(+), 10 deletions(-)

    diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
    index 7eb745b8acce0f..41ae7f96f48194 100644
    --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
    +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
    @@ -862,17 +862,13 @@ int amdgpu_ttm_tt_get_user_pages(struct amdgpu_bo *bo, struct page **pages)
    goto out_free_pfns;
    }

    - for (i = 0; i < ttm->num_pages; i++) {
    - /* FIXME: The pages cannot be touched outside the notifier_lock */
    + /*
    + * Due to default_flags, all pages are HMM_PFN_VALID or
    + * hmm_range_fault() fails. FIXME: The pages cannot be touched outside
    + * the notifier_lock, and mmu_interval_read_retry() must be done first.
    + */
    + for (i = 0; i < ttm->num_pages; i++)
    pages[i] = hmm_device_entry_to_page(range, range->pfns[i]);
    - if (unlikely(!pages[i])) {
    - pr_err("Page fault failed for pfn[%lu] = 0x%llx\n",
    - i, range->pfns[i]);
    - r = -ENOMEM;
    -
    - goto out_free_pfns;
    - }
    - }

    gtt->range = range;
    mmput(mm);
    --
    2.26.2
    \
     
     \ /
      Last update: 2020-05-01 20:21    [W:4.223 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site