lkml.org 
[lkml]   [2020]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    Subject[PATCH v4 02/12] perf metrics: fix parse errors in cascade lake metrics
    From
    Remove over escaping with \\.
    Remove extraneous if 1 if 0 == 1 else 0 else 0.

    Fixes: fd5500989c8f (perf vendor events intel: Update metrics from TMAM 3.5)
    Signed-off-by: Ian Rogers <irogers@google.com>
    ---
    .../pmu-events/arch/x86/cascadelakex/clx-metrics.json | 10 +++++-----
    1 file changed, 5 insertions(+), 5 deletions(-)

    diff --git a/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json b/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json
    index 7fde0d2943cd..d25eebce34c9 100644
    --- a/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json
    +++ b/tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json
    @@ -328,31 +328,31 @@
    },
    {
    "BriefDescription": "Average latency of data read request to external memory (in nanoseconds). Accounts for demand loads and L1/L2 prefetches",
    - "MetricExpr": "1000000000 * ( cha@event\\=0x36\\\\\\,umask\\=0x21@ / cha@event\\=0x35\\\\\\,umask\\=0x21@ ) / ( cha_0@event\\=0x0@ / duration_time )",
    + "MetricExpr": "1000000000 * ( cha@event\\=0x36\\,umask\\=0x21@ / cha@event\\=0x35\\,umask\\=0x21@ ) / ( cha_0@event\\=0x0@ / duration_time )",
    "MetricGroup": "Memory_Lat",
    "MetricName": "DRAM_Read_Latency"
    },
    {
    "BriefDescription": "Average number of parallel data read requests to external memory. Accounts for demand loads and L1/L2 prefetches",
    - "MetricExpr": "cha@event\\=0x36\\\\\\,umask\\=0x21@ / cha@event\\=0x36\\\\\\,umask\\=0x21\\\\\\,thresh\\=1@",
    + "MetricExpr": "cha@event\\=0x36\\,umask\\=0x21@ / cha@event\\=0x36\\,umask\\=0x21\\,thresh\\=1@",
    "MetricGroup": "Memory_BW",
    "MetricName": "DRAM_Parallel_Reads"
    },
    {
    "BriefDescription": "Average latency of data read request to external 3D X-Point memory [in nanoseconds]. Accounts for demand loads and L1/L2 data-read prefetches",
    - "MetricExpr": "( 1000000000 * ( imc@event\\=0xe0\\\\\\,umask\\=0x1@ / imc@event\\=0xe3@ ) / imc_0@event\\=0x0@ ) if 1 if 0 == 1 else 0 else 0",
    + "MetricExpr": "( 1000000000 * ( imc@event\\=0xe0\\,umask\\=0x1@ / imc@event\\=0xe3@ ) / imc_0@event\\=0x0@ )",
    "MetricGroup": "Memory_Lat",
    "MetricName": "MEM_PMM_Read_Latency"
    },
    {
    "BriefDescription": "Average 3DXP Memory Bandwidth Use for reads [GB / sec]",
    - "MetricExpr": "( ( 64 * imc@event\\=0xe3@ / 1000000000 ) / duration_time ) if 1 if 0 == 1 else 0 else 0",
    + "MetricExpr": "( ( 64 * imc@event\\=0xe3@ / 1000000000 ) / duration_time )",
    "MetricGroup": "Memory_BW",
    "MetricName": "PMM_Read_BW"
    },
    {
    "BriefDescription": "Average 3DXP Memory Bandwidth Use for Writes [GB / sec]",
    - "MetricExpr": "( ( 64 * imc@event\\=0xe7@ / 1000000000 ) / duration_time ) if 1 if 0 == 1 else 0 else 0",
    + "MetricExpr": "( ( 64 * imc@event\\=0xe7@ / 1000000000 ) / duration_time )",
    "MetricGroup": "Memory_BW",
    "MetricName": "PMM_Write_BW"
    },
    --
    2.26.2.526.g744177e7f7-goog
    \
     
     \ /
      Last update: 2020-05-01 19:35    [W:4.053 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site