Messages in this thread | | | From | Baolin Wang <> | Date | Fri, 10 Apr 2020 10:15:19 +0800 | Subject | Re: [RFC PATCH 1/3] mfd: syscon: Add reg_update_bits() callback support |
| |
On Thu, Apr 9, 2020 at 10:27 PM Mark Brown <broonie@kernel.org> wrote: > > On Thu, Apr 09, 2020 at 10:13:58PM +0800, Baolin Wang wrote: > > On Thu, Apr 9, 2020 at 6:48 PM Mark Brown <broonie@kernel.org> wrote: > > > > > + int (*reg_update_bits)(void *context, unsigned int reg, > > > > + unsigned int mask, unsigned int val); > > > > This is fine, we already have this operation for buses, but why is this > > > munged in with the MFD patch? > > > Originally I want to show a example usage of the new callback, but I > > can spilt them into 2 patches as you suggested. Thanks. > > Yes, it's good to have an example user - just not as part of the same > patch!
Yes, make sense.
-- Baolin Wang
| |