Messages in this thread | | | Date | Thu, 9 Apr 2020 15:33:35 -0700 | From | Alexei Starovoitov <> | Subject | Re: [RFC PATCH 3/9] writeback: tracing: pass global_wb_domain as tracepoint parameter |
| |
On Thu, Apr 09, 2020 at 03:35:37PM -0400, Mathieu Desnoyers wrote: > if (pause < min_pause) { > - trace_balance_dirty_pages(wb, > + trace_balance_dirty_pages(&global_wb_domain, > + wb, > sdtc->thresh, > sdtc->bg_thresh, > sdtc->dirty,
argh. 13 arguments to single function ?! Currently the call site looks like: trace_balance_dirty_pages(wb, sdtc->thresh, sdtc->bg_thresh, sdtc->dirty, sdtc->wb_thresh, sdtc->wb_dirty, dirty_ratelimit, task_ratelimit, pages_dirtied, period, min(pause, 0L), start_time); Just pass sdtc as a pointer instead. Then another wb argument will be fine.
| |