Messages in this thread | | | Date | Thu, 9 Apr 2020 12:32:19 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH] nfp: Fix memory leak in nfp_resource_acquire() |
| |
On Thu, 9 Apr 2020 17:41:11 +0000 Keita Suzuki wrote: > This patch fixes a memory leak in nfp_resource_acquire(). res->mutex is > alllocated in nfp_resource_try_acquire(). However, when > msleep_interruptible() or time_is_before_eq_jiffies() fails, it falls > into err_fails path where res is freed, but res->mutex is not. > > Fix this by changing call to free to nfp_resource_release().
I don't see a leak here. Maybe you could rephrase the description to make things clearer?
AFAICS nfp_resource_try_acquire() calls nfp_cpp_mutex_free(res->mutex) if it's about to return an error. We can only hit msleep or time check if it returned an error.
| |