lkml.org 
[lkml]   [2020]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1 0/2] Support headset on Tegra boards that use WM8903
From
Date
On 4/9/20 8:52 AM, Dmitry Osipenko wrote:
> 30.03.2020 23:40, Dmitry Osipenko пишет:
>> Hello,
>>
>> Some devices have a 4-pin jack instead of a 3-pin and currently the
>> WM8903 configuration is hardcoded to the case of 3-pin jack in the
>> Tegra's ASoC driver. A new device-tree property is required in order
>> to convey that hardware has a 4-pin jack, and thus, microphone's
>> detection needs to be done in a different way.
>>
>> In particular this is needed for Acer A500 tablet device that has
>> a 4-pin headset jack, otherwise userspace sees headset instead of
>> headphones and internal microphone isn't enabled by ALSA UCM rule
>> when it should be. Please review and apply, thanks in advance.
>>
>> Dmitry Osipenko (2):
>> dt-bindings: sound: tegra-wm8903: Document new nvidia,headset property
>> ASoC: tegra: tegra_wm8903: Support nvidia,headset property
>>
>> .../devicetree/bindings/sound/nvidia,tegra-audio-wm8903.txt | 1 +
>> sound/soc/tegra/tegra_wm8903.c | 6 +++++-
>> 2 files changed, 6 insertions(+), 1 deletion(-)
>>
>
> Jon / Stephen, are you okay with this patchset? Could you please ack it?
> Thanks in advance.

It looks plausible based on commit descriptions, but I don't remember
the details of those APIs well enough to actually review the code change.

\
 
 \ /
  Last update: 2020-04-09 18:55    [W:0.073 / U:1.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site