lkml.org 
[lkml]   [2020]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: virtio-mmio: Delete an error message in vm_find_vqs()
From
Date
>> The function “platform_get_irq” can log an error already.
>> Thus omit a redundant message for the exception handling in the
>> calling function.
>
> It looks to me that not all error path of platform_get_irq() were loggd.

How do you think about to clarify the handling of the error code “-EPROBE_DEFER” any more?
https://elixir.bootlin.com/linux/v5.6.3/source/drivers/base/platform.c#L202


> And git grep told me there're other users of platform_get_irq() that check and log by themselves.

Source code analysis can point further update candidates out, can't it?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/base/platform.c?id=7723f4c5ecdb8d832f049f8483beb0d1081cedf6

Would you like to achieve collateral evolution?

Regards,
Markus

\
 
 \ /
  Last update: 2020-04-09 08:03    [W:0.053 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site