Messages in this thread | | | Date | Thu, 9 Apr 2020 16:32:43 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH v2 2/2] ARM: dts: kirkwood: Add Check Point L-50 board |
| |
On Thu, Apr 09, 2020 at 09:04:44AM +0200, Pawel Dembicki wrote: > This patch adds dts for the Check Point L-50 from 600/1100 series > routers.
Hi Pawel
Looks very good. Just a minor comment:
> +ð1 { > + status = "okay"; > + ethernet1-port@0 { > + speed = <1000>; > + duplex = <1>; > + }; > +};
This is a non-standard way of doing a fixed link. But looking at the driver, that is all it supports. I also don't think it is worth the effort converting it. Kirkwood is so old we hardly see any new boards using it.
So:
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Since we are in the merge window at the moment, this won't be merged for a while.
Andrew
| |