Messages in this thread | | | From | Baolin Wang <> | Date | Thu, 9 Apr 2020 17:56:25 +0800 | Subject | Re: [RFC PATCH 0/3] Add new reg_update_bits() support |
| |
On Thu, Apr 9, 2020 at 5:52 PM Arnd Bergmann <arnd@arndb.de> wrote: > > On Thu, Apr 9, 2020 at 11:40 AM Baolin Wang <baolin.wang7@gmail.com> wrote: > > > > It would be nice in theory to move the sigmatel devices over to > > > reg_update_bits() in theory, but this seems unlikely to actually happen, > > > given that these are mostly obsolete drivers at this point. > > > > I checked all sigmatel devices (about 10 drivers), I think there will > > be more work to change them to use syscon/regmap when changing to > > reg_update_bits(). I am afraid I can not thelp to convert them without > > a hardware, and as you said, some drivers are already dead. So I think > > it would be nice if the driver owners can help to convert these > > drivers, if we get a consensus about the reg_update_bits() > > implementation at last. > > Thanks for taking a closer look. I didn't want to imply that you should > fix them, just saying that it might have been nice if they had been > done like this in the first place. Of course, when the drivers were > written, we did not even have the regmap-mmio helpers at all.
Make sense. Thanks.
-- Baolin Wang
| |