Messages in this thread | | | Subject | Re: [PATCH v1 1/1] pinctrl: mediatek: remove shadow variable declaration | From | Yingjoe Chen <> | Date | Tue, 7 Apr 2020 21:41:25 +0800 |
| |
On Tue, 2020-04-07 at 18:33 +0800, light.hsieh@mediatek.com wrote: > From: Light Hsieh <light.hsieh@mediatek.com> > > Remove shadow declaration of variable 'pullup' in mtk_pinconf_get() > > Signed-off-by: Light Hsieh <light.hsieh@mediatek.com> > --- > drivers/pinctrl/mediatek/pinctrl-paris.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c > index 83bf29c..8f75115 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-paris.c > +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c > @@ -164,8 +164,6 @@ static int mtk_pinconf_get(struct pinctrl_dev *pctldev, > case MTK_PIN_CONFIG_PU_ADV: > case MTK_PIN_CONFIG_PD_ADV: > if (hw->soc->adv_pull_get) { > - bool pullup; > - > pullup = param == MTK_PIN_CONFIG_PU_ADV; > err = hw->soc->adv_pull_get(hw, desc, pullup, &ret); > } else
Hi, Light,
What is this based on? The code in v5.6 doesn't looks like this.
Joe.C
| |