lkml.org 
[lkml]   [2020]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: Add kvfree_sensitive() for freeing sensitive data objects
On Mon, 6 Apr 2020, David Howells wrote:

> David Rientjes <rientjes@google.com> wrote:
>
> > > +static inline void kvfree_sensitive(const void *addr, size_t len)
> > > +{
> > > + if (addr) {
> >
> > Shouldn't this be if (unlikely(ZERO_OR_NULL_PTR(addr))?
>
> You've reversed the logic - it needs a '!' there.
>

Ah lol, yeah. Probably just better to do

if (unlikely(ZERO_OR_NULL_PTR(addr)))
return;

but I agree that mm.h is likely not the right spot.

\
 
 \ /
  Last update: 2020-04-07 01:21    [W:0.190 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site