Messages in this thread | | | Date | Mon, 6 Apr 2020 05:23:43 -0700 | From | Christoph Hellwig <> | Subject | Re: [patch 1/2] x86,module: Detect VMX modules and disable Split-Lock-Detect |
| |
On Thu, Apr 02, 2020 at 02:32:59PM +0200, Thomas Gleixner wrote: > From: Peter Zijlstra <peterz@infradead.org> > > It turns out that with Split-Lock-Detect enabled (default) any VMX > hypervisor needs at least a little modification in order to not blindly > inject the #AC into the guest without the guest being ready for it. > > Since there is no telling which module implements a hypervisor, scan the > module text and look for the VMLAUNCH instruction. If found, the module is > assumed to be a hypervisor of some sort and SLD is disabled. > > Hypervisors, which have been modified and are known to work correctly, > can add: > > MODULE_INFO(sld_safe, "Y"); > > to explicitly tell the module loader they're good. > > NOTE: it is unfortunate that struct load_info is not available to the > arch module code, this means CONFIG_CPU_SUP_INTEL gunk is needed > in generic code. > > NOTE: while we can 'trivially' fix KVM, we're still stuck with stuff > like VMware and VirtualBox doing their own thing.
This is just crazy. We have never cared about any out tree module, why would we care here where it creates a real complexity. Just fix KVM and ignore anything else.
| |