Messages in this thread | | | Date | Mon, 6 Apr 2020 12:34:32 +0200 | From | Krzysztof Kozlowski <> | Subject | Re: [PATCH v5 2/2] tty: samsung_tty: 32-bit access for TX/RX hold registers |
| |
On Mon, Apr 06, 2020 at 07:31:25PM +0900, Hyunki Koo wrote: > Support 32-bit access for the TX/RX hold registers UTXH and URXH. > > This is required for some newer SoCs. > > Signed-off-by: Hyunki Koo <hyunki00.koo@samsung.com> > --- > v2: > line 954 : change rd_regl to rd_reg in for backward compatibility. > line 2031: Add init value for ourport->port.iotype to UPIO_MEM > v3: > line 2031: remove redundant init value for ourport->port.iotype > v4: > correct variable types and change misleading function name > v5: > add dt-binding and go as first patch in this series. > > --- > drivers/tty/serial/samsung_tty.c | 76 +++++++++++++++++++++++++++++++++------- > 1 file changed, 64 insertions(+), 12 deletions(-)
For me it is fine, although Greg wanted the write functions to be consistent with read around default case.
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Tested-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards, Krzysztof
| |