Messages in this thread | | | From | Qiujun Huang <> | Date | Mon, 6 Apr 2020 17:23:24 +0800 | Subject | Re: [PATCH v3] powerpc/powernv: add NULL check after kzalloc in opal_add_one_export |
| |
On Mon, Apr 6, 2020 at 5:01 PM Oliver O'Halloran <oohall@gmail.com> wrote: > > On Mon, Apr 6, 2020 at 11:15 AM Qiujun Huang <hqjagain@gmail.com> wrote: > > > > On Mon, Apr 6, 2020 at 3:06 AM Markus Elfring <Markus.Elfring@web.de> wrote: > > > > > > > Here needs a NULL check. > > quite obvious? > > > > > > I find this change description questionable > > > (despite of a reasonable patch subject). > > > > > > > > > > Issue found by coccinelle. > > > > > > Would an information like “Generated by: scripts/coccinelle/null/kmerr.cocci” > > > be nicer? > > Yeah, but I think It was enough. > > I didn't know we had that script in the kernel tree so I think it's a > good to mention that you used it. It might even help idiots like me > who write this sort of bug.
Yes, I will resend the patch. Thanks :-)
> > > > Will a patch change log be helpful here? > > I realized I should write some change log, and the change log was meaningless. > > So I left it blank. > > The changelog is fine IMO. The point of a changelog is to tell a > reader doing git archeology why a change happened and this is > sufficent for that.
Get that.
> > Reviewed-by: Oliver O'Halloran <oohall@gmail.com>
| |