Messages in this thread | | | Subject | Re: [PATCH v15 4/7] soc: qcom: rpmh-rsc: Save base address of drv | From | Maulik Shah <> | Date | Mon, 6 Apr 2020 10:19:23 +0530 |
| |
Hi,
On 4/2/2020 10:30 PM, Doug Anderson wrote: > Hi, > > On Tue, Mar 31, 2020 at 6:20 AM Maulik Shah <mkshah@codeaurora.org> wrote: >> Add changes to save drv's base address for rsc. This is >> used to read drv's configuration such as solver mode is >> supported or to write into drv's registers. >> >> Signed-off-by: Maulik Shah <mkshah@codeaurora.org> >> --- >> drivers/soc/qcom/rpmh-internal.h | 2 ++ >> drivers/soc/qcom/rpmh-rsc.c | 11 +++++------ >> 2 files changed, 7 insertions(+), 6 deletions(-) > I still see no usage of "drv->base" outside of the probe function even > after applying your whole patch series. That implies that it can just > stay as a local variable. > > If you have a later patch series that needs "drv->base" in some other > RPMH function then this patch should be moved to the front of that > series. Until then it feels like it should be dropped. > > > -Doug
Okay, i will drop this and keep base local to probe only for now.
Thanks, Maulik
-- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
| |