lkml.org 
[lkml]   [2020]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V4 1/4] backlight: qcom-wled: convert the wled bindings to .yaml format
    On Fri, 03 Apr 2020, Daniel Thompson wrote:

    > On Fri, Apr 03, 2020 at 04:45:49PM +0530, kgunda@codeaurora.org wrote:
    > > On 2020-03-31 23:24, Rob Herring wrote:
    > > > On Mon, Mar 23, 2020 at 11:16:55PM +0530, Kiran Gunda wrote:
    > > > > diff --git
    > > > > a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml
    > > > > b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml
    > > > > new file mode 100644
    > > > > index 0000000..8a388bf
    > > > > --- /dev/null
    > > > > +++ b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml
    > > > > @@ -0,0 +1,184 @@
    > > > > +# SPDX-License-Identifier: GPL-2.0-only
    > > > > +%YAML 1.2
    > > > > +---
    > > > > +$id: http://devicetree.org/schemas/leds/backlight/qcom-wled.yaml#
    > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
    > > > > +
    > > > > +title: Binding for Qualcomm Technologies, Inc. WLED driver
    > > > > +
    > > > > +maintainers:
    > > > > + - Lee Jones <lee.jones@linaro.org>
    > > >
    > > > Should be the h/w owner (you), not who applies patches.
    > > >
    > > will address in next post.
    > > <snip>
    > > will address in next post.
    > > <snip>
    > > will address in next post.
    > > <snip>
    > > will address in next post.
    > > <snip>
    > > will address in next post.
    > > <snip>
    > > will address in next post.
    > > <snip>
    > > will address in next post.
    > > <snip>
    > > will address in next post.
    > > <snip>
    > > will address in next post.
    >
    > If you agree on all points raised I doubt there is any need for a point
    > by point reply since everyone who reads it will have to scroll down
    > simply to find out that you agree on all points.
    >
    > Better just to acknowledge the feedback and reply to the first one
    > saying you'll agree on all points and will address all feedback in the
    > next revision (and then trim the reply to keep it short).

    Or better still, just submit the next revision with all the fixes. :)

    --
    Lee Jones [李琼斯]
    Linaro Services Technical Lead
    Linaro.org │ Open source software for ARM SoCs
    Follow Linaro: Facebook | Twitter | Blog

    \
     
     \ /
      Last update: 2020-04-06 10:50    [W:5.824 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site