Messages in this thread | | | Date | Mon, 6 Apr 2020 16:48:20 -0700 | From | Nicolin Chen <> | Subject | Re: [PATCH v6 5/7] ASoC: fsl_asrc: Move common definition to fsl_asrc_common |
| |
On Wed, Apr 01, 2020 at 04:45:38PM +0800, Shengjiu Wang wrote:
> static int fsl_asrc_probe(struct platform_device *pdev) > { > struct device_node *np = pdev->dev.of_node; > struct fsl_asrc *asrc; > + struct fsl_asrc_priv *asrc_priv;
Could we move it before "struct fsl_asrc *asrc;"?
> diff --git a/sound/soc/fsl/fsl_asrc_common.h b/sound/soc/fsl/fsl_asrc_common.h > new file mode 100644 > index 000000000000..5c93ccdfc30a > --- /dev/null > +++ b/sound/soc/fsl/fsl_asrc_common.h
> +#define PAIR_CTX_NUM 0x4 > +#define PAIR_PRIVAT_SIZE 0x400
"PRIVAT_" => "PRIVATE_"
> +/** > + * fsl_asrc_pair: ASRC common data
"fsl_asrc_pair" => "fsl_asrc"
> + */ > +struct fsl_asrc {
> diff --git a/sound/soc/fsl/fsl_asrc_dma.c b/sound/soc/fsl/fsl_asrc_dma.c > index b15946e03380..5cf0468ce6e3 100644 > --- a/sound/soc/fsl/fsl_asrc_dma.c > +++ b/sound/soc/fsl/fsl_asrc_dma.c
> @@ -311,11 +311,12 @@ static int fsl_asrc_dma_startup(struct snd_soc_component *component, > return ret; > } > > - pair = kzalloc(sizeof(struct fsl_asrc_pair), GFP_KERNEL); > + pair = kzalloc(sizeof(struct fsl_asrc_pair) + PAIR_PRIVAT_SIZE, GFP_KERNEL);
If we only use the PAIR_PRIVATE_SIZE here, maybe we can put the define in this file too, rather than in the header file.
And could fit 80 characters:
+ pair = kzalloc(sizeof(*pair) + PAIR_PRIVAT_SIZE, GFP_KERNEL);
| |