Messages in this thread | | | From | Dexuan Cui <> | Subject | RE: [PATCH v2 net] skbuff.h: Improve the checksum related comments | Date | Mon, 6 Apr 2020 01:51:35 +0000 |
| |
> From: Randy Dunlap <rdunlap@infradead.org> > Sent: Sunday, April 5, 2020 6:43 PM > On 4/5/20 6:26 PM, Dexuan Cui wrote: > > @@ -211,9 +211,9 @@ > > * is implied by the SKB_GSO_* flags in gso_type. Most obviously, if the > > * gso_type is SKB_GSO_TCPV4 or SKB_GSO_TCPV6, TCP checksum offload > as > > * part of the GSO operation is implied. If a checksum is being offloaded > > - * with GSO then ip_summed is CHECKSUM_PARTIAL, csum_start and > csum_offset > > - * are set to refer to the outermost checksum being offload (two offloaded > > - * checksums are possible with UDP encapsulation). > > + * with GSO then ip_summed is CHECKSUM_PARTIAL, and both csum_start > and > > + * csum_offset are set to refer to the outermost checksum being offload > (two > > > being offloaded
Thanks for spotting this! :-)
> > Reviewed-by: Randy Dunlap <rdunlap@infradead.org> > -- > ~Randy
Will post a v3 shortly.
Thanks, -- Dexuan
| |